From: Ronald Oussoren <ronaldoussoren@mac.com>
Date: Tue, 22 Nov 2022 10:33:37 +0000 (+0100)
Subject: GH-92892: Add section about variadic functions to ctypes documentation (#99529)
X-Git-Tag: v3.12.0a3~142
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bc3a11d21ddef28047b18c0f6a5068fa9fb16da2;p=thirdparty%2FPython%2Fcpython.git

GH-92892: Add section about variadic functions to ctypes documentation (#99529)

On some platforms, and in particular macOS/arm64, the calling
convention for variadic arguments is different from the regular
calling convention. Add a section to the documentation to document
this.
---

diff --git a/Doc/library/ctypes.rst b/Doc/library/ctypes.rst
index e85a6cb7149c..71e5545ffe47 100644
--- a/Doc/library/ctypes.rst
+++ b/Doc/library/ctypes.rst
@@ -373,6 +373,26 @@ that they can be converted to the required C data type::
    31
    >>>
 
+.. _ctypes-calling-variadic-functions:
+
+Calling varadic functions
+^^^^^^^^^^^^^^^^^^^^^^^^^
+
+On a lot of platforms calling variadic functions through ctypes is exactly the same
+as calling functions with a fixed number of parameters. On some platforms, and in
+particular ARM64 for Apple Platforms, the calling convention for variadic functions
+is different than that for regular functions.
+
+On those platforms it is required to specify the *argtypes* attribute for the
+regular, non-variadic, function arguments:
+
+.. code-block:: python3
+
+   libc.printf.argtypes = [ctypes.c_char_p]
+
+Because specifying the attribute does inhibit portability it is adviced to always
+specify ``argtypes`` for all variadic functions.
+
 
 .. _ctypes-calling-functions-with-own-custom-data-types:
 
diff --git a/Misc/NEWS.d/next/Documentation/2022-11-16-12-52-23.gh-issue-92892.TS-P0j.rst b/Misc/NEWS.d/next/Documentation/2022-11-16-12-52-23.gh-issue-92892.TS-P0j.rst
new file mode 100644
index 000000000000..54e421d19d9d
--- /dev/null
+++ b/Misc/NEWS.d/next/Documentation/2022-11-16-12-52-23.gh-issue-92892.TS-P0j.rst
@@ -0,0 +1 @@
+Document that calling variadic functions with ctypes requires special care on macOS/arm64 (and possibly other platforms).