From: Victor Stinner <victor.stinner@gmail.com>
Date: Wed, 19 Oct 2016 08:11:37 +0000 (+0200)
Subject: Close #28476: Reuse math.factorial() in test_random
X-Git-Tag: v3.7.0a1~2201
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bd1b49a242f8430c4f3730ab44f044b67017838b;p=thirdparty%2FPython%2Fcpython.git

Close #28476: Reuse math.factorial() in test_random

Patch written by Francisco Couzo.
---

diff --git a/Lib/test/test_random.py b/Lib/test/test_random.py
index 4d5a8749c76c..d061829aa028 100644
--- a/Lib/test/test_random.py
+++ b/Lib/test/test_random.py
@@ -5,7 +5,7 @@ import time
 import pickle
 import warnings
 from functools import partial
-from math import log, exp, pi, fsum, sin
+from math import log, exp, pi, fsum, sin, factorial
 from test import support
 from fractions import Fraction
 
@@ -117,10 +117,6 @@ class TestBasicOps:
         n = 5
         pop = range(n)
         trials = 10000  # large num prevents false negatives without slowing normal case
-        def factorial(n):
-            if n == 0:
-                return 1
-            return n * factorial(n - 1)
         for k in range(n):
             expected = factorial(n) // factorial(n-k)
             perms = {}