From: Andreas Schneider Date: Wed, 8 May 2019 14:27:57 +0000 (+0200) Subject: s4:auth: Fix debug statement in gensec_gssapi X-Git-Tag: tdb-1.4.1~162 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bd29f3fcc023d00afde8e9cc2f9db22dcae49877;p=thirdparty%2Fsamba.git s4:auth: Fix debug statement in gensec_gssapi The 'role' is set to null, we should first set it to the correct value before printing anything. Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison --- diff --git a/source4/auth/gensec/gensec_gssapi.c b/source4/auth/gensec/gensec_gssapi.c index a61b2b2659c..4577c91c93a 100644 --- a/source4/auth/gensec/gensec_gssapi.c +++ b/source4/auth/gensec/gensec_gssapi.c @@ -703,11 +703,7 @@ init_sec_context_done: OM_uint32 lifetime = 0; gss_cred_usage_t usage; const char *role = NULL; - DEBUG(0, ("GSS %s Update(krb5)(%d) Update failed, credentials expired during GSSAPI handshake!\n", - role, - gensec_gssapi_state->gss_exchange_count)); - switch (gensec_security->gensec_role) { case GENSEC_CLIENT: creds = gensec_gssapi_state->client_cred->creds; @@ -719,6 +715,11 @@ init_sec_context_done: break; } + DBG_ERR("GSS %s Update(krb5)(%d) failed, credentials " + "expired during GSSAPI handshake!\n", + role, + gensec_gssapi_state->gss_exchange_count); + maj_stat = gss_inquire_cred(&min_stat, creds, &name, &lifetime, &usage, NULL);