From: Volker Lendecke Date: Wed, 9 May 2012 08:56:54 +0000 (+0200) Subject: s3: Fix Coverity ID 242717 Uninitialized scalar variable X-Git-Tag: samba-4.0.0alpha21~221 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bd4701d2869c8f5271c72fe4271c2ba4772acfad;p=thirdparty%2Fsamba.git s3: Fix Coverity ID 242717 Uninitialized scalar variable In an error path we are closing domain_pol without opening it --- diff --git a/source3/rpcclient/cmd_samr.c b/source3/rpcclient/cmd_samr.c index ebc13c33347..022230becb5 100644 --- a/source3/rpcclient/cmd_samr.c +++ b/source3/rpcclient/cmd_samr.c @@ -2703,7 +2703,8 @@ static NTSTATUS cmd_samr_chgpasswd(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx, int argc, const char **argv) { - struct policy_handle connect_pol, domain_pol; + struct policy_handle connect_pol; + struct policy_handle domain_pol = { 0, }; struct policy_handle user_pol = { 0, }; NTSTATUS status, result; const char *user, *oldpass, *newpass;