From: Michael Matirko (mmatirko) <mmatirko@cisco.com>
Date: Tue, 4 Nov 2025 09:43:22 +0000 (+0000)
Subject: Pull request #4970: stream: remove lock on extra_data_log as it is only changed at... 
X-Git-Tag: 3.9.7.0~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bd5a3e85a0a25e7dda1b48c151f38d722712e70a;p=thirdparty%2Fsnort3.git

Pull request #4970: stream: remove lock on extra_data_log as it is only changed at Analyzer startup

Merge in SNORT/snort3 from ~MMATIRKO/snort3:xtra_no_lock to master

Squashed commit of the following:

commit a59a788ca121a1df8bd111eec08b19e7437dad6b
Author: Michael Matirko <mmatirko@cisco.com>
Date:   Mon Nov 3 09:49:45 2025 -0500

    stream: remove lock on extra_data_log as it is only changed at Analyzer startup
---

diff --git a/src/stream/stream.cc b/src/stream/stream.cc
index 0611241a7..e0dcea2e4 100644
--- a/src/stream/stream.cc
+++ b/src/stream/stream.cc
@@ -499,10 +499,9 @@ StreamSplitter* Stream::get_splitter(Flow* flow, bool to_server)
 void Stream::log_extra_data(
     Flow* flow, uint32_t mask, const AlertInfo& alert_info)
 {
-    std::lock_guard<std::mutex> xtra_lock(stream_xtra_mutex);
+    // coverity[missing_lock]
     if ( mask && stream.extra_data_log )
     {
-
         stream.extra_data_log(
             flow, stream.extra_data_context, stream.xtradata_map,
             stream.xtradata_func_count, mask, alert_info);