From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 30 Apr 2019 11:47:52 +0000 (+0200)
Subject: logind: validate /sys fs path a bit more strictly
X-Git-Tag: v243-rc1~295^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bda0613072b82c357e11cdc2171593dffd0e8d31;p=thirdparty%2Fsystemd.git

logind: validate /sys fs path a bit more strictly
---

diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index 1623151f8c3..e1b182150b4 100644
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -1404,6 +1404,8 @@ static int method_attach_device(sd_bus_message *message, void *userdata, sd_bus_
         if (r < 0)
                 return r;
 
+        if (!path_is_normalized(sysfs))
+                return sd_bus_error_setf(error, SD_BUS_ERROR_INVALID_ARGS, "Path %s is not normalized", sysfs);
         if (!path_startswith(sysfs, "/sys"))
                 return sd_bus_error_setf(error, SD_BUS_ERROR_INVALID_ARGS, "Path %s is not in /sys", sysfs);