From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 25 Mar 2024 09:21:19 +0000 (+1300)
Subject: ldb: Add more segfault tests DN handling
X-Git-Tag: tdb-1.4.11~1185
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bda4e1233a145f11aa92b89a5658d94cd9252267;p=thirdparty%2Fsamba.git

ldb: Add more segfault tests DN handling

- from_dict DN use-after-free
- check for the same directly creating the ldb.Message

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/python/samba/tests/segfault.py b/python/samba/tests/segfault.py
index 2b543dc6382..8b1676a90d0 100644
--- a/python/samba/tests/segfault.py
+++ b/python/samba/tests/segfault.py
@@ -375,6 +375,46 @@ class SegfaultTests(samba.tests.TestCase):
             del msg
             dn.get_casefold()
 
+    @no_gdb_backtrace
+    @segfault_detector
+    def test_ldb_use_after_dict_init(self):
+
+        msg = ldb.Message()
+
+        samdb = self.get_samdb()
+        msg.dn = ldb.Dn(samdb, "CN=Test")
+
+        msg2 = ldb.Message.from_dict(samdb,
+                                     {"dn": msg.dn,
+                                      "foo": ["bar"]})
+        del msg
+        dn = msg2.dn
+        dn.add_child("CN=TEST")
+        dn.set_component(0, "CN", "Test2")
+
+        del samdb
+
+        dn.get_casefold()
+
+    @no_gdb_backtrace
+    @segfault_detector
+    def test_ldb_use_after_msg_init(self):
+
+        msg = ldb.Message()
+
+        samdb = self.get_samdb()
+        msg.dn = ldb.Dn(samdb, "CN=Test")
+
+        msg2 = ldb.Message(dn=msg.dn)
+        del msg
+        dn = msg2.dn
+        dn.add_child("CN=TEST")
+        dn.set_component(0, "CN", "Test2")
+
+        del samdb
+
+        dn.get_casefold()
+
     @no_gdb_backtrace
     @segfault_detector
     def test_ldb_use_after_free_msg_diff(self):