From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 26 Mar 2021 05:22:17 +0000 (+1300)
Subject: pydns: rename s/CNameRecord/CNAMERecord/ for consistency
X-Git-Tag: tevent-0.11.0~1252
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bdc2567324c6b8069d3fd809ed1d1d68bd92a9d7;p=thirdparty%2Fsamba.git

pydns: rename s/CNameRecord/CNAMERecord/ for consistency

Everything else is TXTRecord, SRVRrcord, SOARecord.

Making CNAME the same allows easier lookups.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/python/samba/dnsserver.py b/python/samba/dnsserver.py
index 6d8a72919df..4f965a1ec9e 100644
--- a/python/samba/dnsserver.py
+++ b/python/samba/dnsserver.py
@@ -65,11 +65,11 @@ class PTRRecord(dnsserver.DNS_RPC_RECORD):
         self.data = ptr_name
 
 
-class CNameRecord(dnsserver.DNS_RPC_RECORD):
+class CNAMERecord(dnsserver.DNS_RPC_RECORD):
 
     def __init__(self, cname, serial=1, ttl=900, rank=dnsp.DNS_RANK_ZONE,
                  node_flag=0):
-        super(CNameRecord, self).__init__()
+        super().__init__()
         self.wType = dnsp.DNS_TYPE_CNAME
         self.dwFlags = rank | node_flag
         self.dwSerial = serial
diff --git a/python/samba/join.py b/python/samba/join.py
index d78375441fb..97745a3901a 100644
--- a/python/samba/join.py
+++ b/python/samba/join.py
@@ -41,7 +41,7 @@ from samba import werror
 from base64 import b64encode
 from samba import WERRORError, NTSTATUSError
 from samba import sd_utils
-from samba.dnsserver import ARecord, AAAARecord, CNameRecord
+from samba.dnsserver import ARecord, AAAARecord, CNAMERecord
 import logging
 import random
 import time
@@ -1192,7 +1192,7 @@ class DCJoinContext(object):
                             % (msdcs_cname, msdcs_zone, cname_target))
 
             add_rec_buf = dnsserver.DNS_RPC_RECORD_BUF()
-            rec = CNameRecord(cname_target)
+            rec = CNAMERecord(cname_target)
             add_rec_buf.rec = rec
             dns_conn.DnssrvUpdateRecord2(client_version,
                                          0,
diff --git a/python/samba/netcmd/dns.py b/python/samba/netcmd/dns.py
index d4b06929aa3..dd1cf474c0f 100644
--- a/python/samba/netcmd/dns.py
+++ b/python/samba/netcmd/dns.py
@@ -40,7 +40,7 @@ from samba.netcmd import (
 )
 from samba.dcerpc import dnsp, dnsserver
 
-from samba.dnsserver import ARecord, AAAARecord, PTRRecord, CNameRecord, NSRecord, MXRecord, SOARecord, SRVRecord, TXTRecord
+from samba.dnsserver import ARecord, AAAARecord, PTRRecord, CNAMERecord, NSRecord, MXRecord, SOARecord, SRVRecord, TXTRecord
 
 
 def dns_connect(server, lp, creds):
@@ -413,7 +413,7 @@ def data_to_dns_record(record_type, data):
     elif record_type == dnsp.DNS_TYPE_PTR:
         rec = PTRRecord(data)
     elif record_type == dnsp.DNS_TYPE_CNAME:
-        rec = CNameRecord(data)
+        rec = CNAMERecord(data)
     elif record_type == dnsp.DNS_TYPE_NS:
         rec = NSRecord(data)
     elif record_type == dnsp.DNS_TYPE_MX: