From: Andrei Pavel <andrei@isc.org>
Date: Mon, 2 Oct 2023 11:33:50 +0000 (+0300)
Subject: [#3068] fix shadowed member
X-Git-Tag: Kea-2.5.3~49
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bdc33276da22bba727a656a0940fdecfd12942a7;p=thirdparty%2Fkea.git

[#3068] fix shadowed member

data.cc: In member function ‘virtual void isc::data::MapElement::toJSON(std::ostream&) const’:
data.cc:919:51: warning: declaration of ‘m’ shadows a member of ‘isc::data::MapElement’ [-Wshadow]
  919 |     const std::map<std::string, ConstElementPtr>& m = mapValue();
      |                                                   ^
In file included from data.cc:9:
../../../src/lib/cc/data.h:769:44: note: shadowed declaration is here
  769 |     std::map<std::string, ConstElementPtr> m;
      |                                            ^
---

diff --git a/src/lib/cc/data.cc b/src/lib/cc/data.cc
index 2f69f27a8c..742a99b861 100644
--- a/src/lib/cc/data.cc
+++ b/src/lib/cc/data.cc
@@ -916,7 +916,6 @@ void
 MapElement::toJSON(std::ostream& ss) const {
     ss << "{ ";
 
-    const std::map<std::string, ConstElementPtr>& m = mapValue();
     for (auto it = m.begin(); it != m.end(); ++it) {
         if (it != m.begin()) {
             ss << ", ";