From: Jason Kirtland <jek@discorporate.us>
Date: Wed, 12 Dec 2007 20:18:58 +0000 (+0000)
Subject: Some code-level docs for r3916
X-Git-Tag: rel_0_4_2~62
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bdd922ad0d94953c53e654893889e5aa7ed00685;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Some code-level docs for r3916
---

diff --git a/lib/sqlalchemy/databases/mysql.py b/lib/sqlalchemy/databases/mysql.py
index ba0ad5e0af..122c24bff5 100644
--- a/lib/sqlalchemy/databases/mysql.py
+++ b/lib/sqlalchemy/databases/mysql.py
@@ -1882,6 +1882,11 @@ class MySQLCompiler(compiler.DefaultCompiler):
             return ""
 
     def visit_join(self, join, asfrom=False, **kwargs):
+        # 'JOIN ... ON ...' for inner joins isn't available until 4.0.
+        # Apparently < 3.23.17 requires theta joins for inner joins
+        # (but not outer).  Not generating these currently, but
+        # support can be added, preferably after dialects are
+        # refactored to be version-sensitive.
         return ''.join(
             (self.process(join.left, asfrom=True),
              (join.isouter and " LEFT OUTER JOIN " or " INNER JOIN "),