From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 1 Sep 2009 19:51:09 +0000 (-0400)
Subject: Use an _actual_ fix for the byte-reverse warning.
X-Git-Tag: tor-0.2.2.2-alpha~50^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bddda9bbdb047e52652f7c6f9c2047df15a4e08e;p=thirdparty%2Ftor.git

Use an _actual_ fix for the byte-reverse warning.

(Given that we're pretty much assuming that int is 32 bits, and given that
hex values are always unsigned, taking out the "ul" from 0xff000000 should
be fine.)
---

diff --git a/src/common/address.c b/src/common/address.c
index 3e0ea25d90..2fe013a2cd 100644
--- a/src/common/address.c
+++ b/src/common/address.c
@@ -374,10 +374,10 @@ tor_addr_parse_reverse_lookup_name(tor_addr_t *result, const char *address,
 
     /* reverse the bytes */
     inaddr.s_addr = (uint32_t)
-      (((inaddr.s_addr & 0x000000fful) << 24)
-       |((inaddr.s_addr & 0x0000ff00ul) << 8)
-       |((inaddr.s_addr & 0x00ff0000ul) >> 8)
-       |((inaddr.s_addr & 0xff000000ul) >> 24));
+      (((inaddr.s_addr & 0x000000ff) << 24)
+       |((inaddr.s_addr & 0x0000ff00) << 8)
+       |((inaddr.s_addr & 0x00ff0000) >> 8)
+       |((inaddr.s_addr & 0xff000000) >> 24));
 
     if (result) {
       tor_addr_from_in(result, &inaddr);