From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 2 Feb 2010 23:26:34 +0000 (+0000)
Subject: the order of rollback()s wasn't correct.  slightly disturbing as the test usually... 
X-Git-Tag: rel_0_6beta1~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bde3ceb1d9bc290de168fa125c9c9730aa76fe27;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

the order of rollback()s wasn't correct.  slightly disturbing as the test usually passed,
began failing on PG as of somewhat unrelated commit r6705, and only when the full test/engine series
of tests were run.  very heisenbuggy. may want to add tests to assert that TLEngine is enforcing
nesting even with subtransactions.
---

diff --git a/test/engine/test_transaction.py b/test/engine/test_transaction.py
index 5be1d93740..de2cc46d33 100644
--- a/test/engine/test_transaction.py
+++ b/test/engine/test_transaction.py
@@ -829,6 +829,12 @@ class TLTransactionTest(TestBase):
         tlengine.begin()
         tlengine.execute(users.insert(), user_id=3, user_name='user3')
         tlengine.rollback()
+        
+        # TODO: removing this line, the test still tends to pass in most
+        # cases, except sporadically on PG.  this should be nailed down
+        # in TLEngine - removing this line should be guaranteed fail.
+        tlengine.rollback()
+        
         tlengine.execute(users.insert(), user_id=4, user_name='user4')
         tlengine.commit()
         tlengine.close()