From: Pablo Galindo Date: Sun, 29 Dec 2019 20:18:36 +0000 (+0000) Subject: Fix error when running with -uall in test_unparse (GH-17739) X-Git-Tag: v3.9.0a3~180 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be287c319124b7eb59ef32b69cf837ae3e99acab;p=thirdparty%2FPython%2Fcpython.git Fix error when running with -uall in test_unparse (GH-17739) --- diff --git a/Lib/test/test_unparse.py b/Lib/test/test_unparse.py index 3e796860cbcf..49767dbac16d 100644 --- a/Lib/test/test_unparse.py +++ b/Lib/test/test_unparse.py @@ -303,17 +303,17 @@ class DirectoryTestCase(ASTTestCase): if not item.name.startswith("bad") ] - tests_to_run_always = {item for item in items if - item.name in cls.run_always_files} - # Test limited subset of files unless the 'cpu' resource is specified. if not test.support.is_resource_enabled("cpu"): - items = set(random.sample(items, 10)) - # Make sure that at least tests that heavily use grammar features are - # considered to reduce the change of missing something. + tests_to_run_always = {item for item in items if + item.name in cls.run_always_files} + + items = set(random.sample(items, 10)) - items = list(items | tests_to_run_always) + # Make sure that at least tests that heavily use grammar features are + # always considered in order to reduce the chance of missing something. + items = list(items | tests_to_run_always) # bpo-31174: Store the names sample to always test the same files. # It prevents false alarms when hunting reference leaks.