From: Noel Power Date: Thu, 11 Jul 2019 11:31:03 +0000 (+0000) Subject: s4/libcli: clang: Fix 'initialization value is never read' X-Git-Tag: talloc-2.3.0~81 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be319e24bb96ac4acbf55f36403f37af08107660;p=thirdparty%2Fsamba.git s4/libcli: clang: Fix 'initialization value is never read' Fixes: source4/libcli/smb_composite/fetchfile.c:91:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_UNSUCCESSFUL; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/source4/libcli/smb_composite/fetchfile.c b/source4/libcli/smb_composite/fetchfile.c index dc6f71b452e..30e3a626ce6 100644 --- a/source4/libcli/smb_composite/fetchfile.c +++ b/source4/libcli/smb_composite/fetchfile.c @@ -88,7 +88,7 @@ static NTSTATUS fetchfile_read(struct composite_context *c, static void fetchfile_state_handler(struct composite_context *c) { struct fetchfile_state *state; - NTSTATUS status = NT_STATUS_UNSUCCESSFUL; + NTSTATUS status; state = talloc_get_type(c->private_data, struct fetchfile_state); @@ -101,6 +101,9 @@ static void fetchfile_state_handler(struct composite_context *c) case FETCHFILE_READ: status = fetchfile_read(c, state->io); break; + default: + status = NT_STATUS_UNSUCCESSFUL; + break; } if (!NT_STATUS_IS_OK(status)) {