From: Peter Krempa Date: Tue, 7 May 2019 14:47:00 +0000 (+0200) Subject: docs: hacking: Document few practices for creating error messages X-Git-Tag: v5.4.0-rc1~27 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be432131ee66401bff275c66b44fe4c631b57a01;p=thirdparty%2Flibvirt.git docs: hacking: Document few practices for creating error messages State that error messages should not be broken into multiple lines for programmer friendliness and should not be concatenated on the fly for translator friendliness and few other details. Signed-off-by: Peter Krempa ACKed-by: Eric Blake --- diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 902d05430f..081d793360 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -1284,6 +1284,34 @@ does for snprintf.

+

Error message format

+ +

+ Error messages visible to the user should be short and descriptive. All + error messages are translated using gettext and thus must be wrapped in + _() macro. To simplify the translation work, the error message + must not be concatenated from various parts. To simplify searching for + the error message in the code the strings should not be broken even + if they result into a line longer than 80 columns and any formatting + modifier should be enclosed by quotes or other obvious separator. + If a string used with %s can be NULL the NULLSTR macro must + be used. +

+ +
+  GOOD: virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("Failed to connect to remote host '%s'"), hostname)
+
+  BAD: virReportError(VIR_ERR_INTERNAL_ERROR,
+                      _("Failed to %s to remote host '%s'"),
+                      "connect", hostname);
+
+  BAD: virReportError(VIR_ERR_INTERNAL_ERROR,
+                      _("Failed to connect "
+                      "to remote host '%s'),
+                      hostname);
+
+

Use of goto