From: Nick Coghlan <ncoghlan@gmail.com>
Date: Sun, 17 Jun 2012 08:57:20 +0000 (+1000)
Subject: Issue #15043: skip test_gdb if the custom hooks can't be loaded
X-Git-Tag: v3.3.0b1~206^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be4e4b5691492008dae31c82dc6ac2aba230b4e5;p=thirdparty%2FPython%2Fcpython.git

Issue #15043: skip test_gdb if the custom hooks can't be loaded
---

diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
index aea7c0c3eecc..a02f5c754efe 100644
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -32,6 +32,15 @@ gdbpy_version, _ = p.communicate()
 if gdbpy_version == b'':
     raise unittest.SkipTest("gdb not built with embedded python support")
 
+# Verify that "gdb" can load our custom hooks
+p = subprocess.Popen(["gdb", "--batch", cmd,
+                      "--args", sys.executable],
+                     stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+__, gdbpy_errors = p.communicate()
+if b"auto-loading has been declined" in gdbpy_errors:
+    msg = "gdb security settings prevent use of custom hooks: %s"
+    raise unittest.SkipTest(msg % gdbpy_errors)
+
 def gdb_has_frame_select():
     # Does this build of gdb have gdb.Frame.select ?
     cmd = "--eval-command=python print(dir(gdb.Frame))"
diff --git a/Misc/NEWS b/Misc/NEWS
index f9abb667202b..53b596696c76 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -301,6 +301,9 @@ Extension Modules
 Tests
 -----
 
+- Issue #15043: test_gdb is now skipped entirely if gdb security settings
+  block loading of the gdb hooks
+
 - Issue #14026: In test_cmd_line_script, check that sys.argv is populated
   correctly for the various invocation approaches (Patch by Jason Yeo)