From: Bert Hubert <bert.hubert@netherlabs.nl>
Date: Fri, 4 Jan 2013 07:09:40 +0000 (+0000)
Subject: Mark Zealey discovered we were retrieving the ascii powerdns version string for each... 
X-Git-Tag: auth-3.2-rc4~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be6c6b392496d22b8221d597ad6d20141326e774;p=thirdparty%2Fpdns.git

Mark Zealey discovered we were retrieving the ascii powerdns version string for each packet, not just for version string queries. Patch from ticket 651.


git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@3018 d19b8d6e-7fed-0310-83ef-9ca221ded41b
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index bd348b9858..df4fd14463 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -260,10 +260,10 @@ int PacketHandler::doVersionRequest(DNSPacket *p, DNSPacket *r, string &target)
 {
   DNSResourceRecord rr;
   
-  // modes: anonymous, powerdns only, full, spoofed
-  const string mode=::arg()["version-string"];
-  
   if(p->qclass == QClass::CHAOS && p->qtype.getCode()==QType::TXT && target=="version.bind") {// TXT
+    // modes: anonymous, powerdns only, full, spoofed
+    const static string mode=::arg()["version-string"];
+  
     if(mode.empty() || mode=="full") 
       rr.content="Served by POWERDNS "VERSION" $Id$";
     else if(mode=="anonymous") {