From: Susant Sahani <ssahani@gmail.com>
Date: Fri, 10 May 2019 12:17:45 +0000 (+0530)
Subject: LLDP: Fix logs for LLDP
X-Git-Tag: v243-rc1~452^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be7468f07ad2b0265033545bff9462ab0391e96d;p=thirdparty%2Fsystemd.git

LLDP: Fix logs for LLDP

```
May 10 11:08:54 test systemd-networkd[447]: wwan0: Failed to stop LLDP: Success
May 10 11:08:54 test systemd-networkd[447]: wwan0: Gained carrier
May 10 11:08:54 test systemd-networkd[447]: wwan0: Failed to start LLDP: Success
```
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 9c6dc4d6d67..af83cb49351 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -3027,16 +3027,16 @@ static int link_update_lldp(Link *link) {
 
         if (link->flags & IFF_UP) {
                 r = sd_lldp_start(link->lldp);
+                if (r < 0)
+                        return log_link_warning_errno(link, r, "Failed to start LLDP: %m");
                 if (r > 0)
                         log_link_debug(link, "Started LLDP.");
-                else
-                        log_link_warning_errno(link, r, "Failed to start LLDP: %m");
         } else {
                 r = sd_lldp_stop(link->lldp);
+                if (r < 0)
+                        return log_link_warning_errno(link, r, "Failed to stop LLDP: %m");
                 if (r > 0)
                         log_link_debug(link, "Stopped LLDP.");
-                else
-                        log_link_warning_errno(link, r, "Failed to stop LLDP: %m");
         }
 
         return r;