From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 29 Apr 2020 12:15:27 +0000 (+0300)
Subject: login-proxy: client_proxy_failed() - minor code cleanup
X-Git-Tag: 2.3.13~694
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be74825abf91e95064a0f5c565a8ddc24707012c;p=thirdparty%2Fdovecot%2Fcore.git

login-proxy: client_proxy_failed() - minor code cleanup

The comment wasn't true anymore.
---

diff --git a/src/login-common/client-common-auth.c b/src/login-common/client-common-auth.c
index a8bc41a430..eb70adbae1 100644
--- a/src/login-common/client-common-auth.c
+++ b/src/login-common/client-common-auth.c
@@ -306,9 +306,8 @@ void client_proxy_log_failure(struct client *client, const char *line)
 
 void client_proxy_failed(struct client *client, bool send_line)
 {
-	if (send_line) {
+	if (send_line)
 		client_proxy_error(client, PROXY_FAILURE_MSG);
-	}
 
 	if (client->proxy_sasl_client != NULL)
 		dsasl_client_free(&client->proxy_sasl_client);
@@ -317,7 +316,6 @@ void client_proxy_failed(struct client *client, bool send_line)
 	i_free_and_null(client->proxy_user);
 	i_free_and_null(client->proxy_master_user);
 
-	/* call this last - it may destroy the client */
 	client_auth_failed(client);
 }