From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 14 Sep 2021 21:11:55 +0000 (+0200)
Subject: fileio: set O_NOCTTY when reading virtual files
X-Git-Tag: v250-rc1~666^2~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=be991d7678c35aa037ef79672c0c70781eebed9c;p=thirdparty%2Fsystemd.git

fileio: set O_NOCTTY when reading virtual files

Better be safe than sorry, maybe someone points this call to a TTY one
day, and we'd rather not make it our controlling TTY in that case.
---

diff --git a/src/basic/fileio.c b/src/basic/fileio.c
index af7ae5b1b8f..efed64cda0f 100644
--- a/src/basic/fileio.c
+++ b/src/basic/fileio.c
@@ -395,7 +395,7 @@ int read_virtual_file(const char *filename, size_t max_size, char **ret_contents
          * contents* may be returned. (Though the read is still done using one syscall.) Returns 0 on
          * partial success, 1 if untruncated contents were read. */
 
-        fd = open(filename, O_RDONLY|O_CLOEXEC);
+        fd = open(filename, O_RDONLY|O_NOCTTY|O_CLOEXEC);
         if (fd < 0)
                 return -errno;