From: Bob Halley <halley@dnspython.org>
Date: Tue, 23 Aug 2022 12:23:08 +0000 (-0700)
Subject: When scanning interfaces with WMI, ignore those without DNS
X-Git-Tag: v2.3.0rc1~52
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bef190ed2b947d2e566b558205f2bf8233002f09;p=thirdparty%2Fdnspython.git

When scanning interfaces with WMI, ignore those without DNS
configuration.  [#834]
---

diff --git a/dns/win32util.py b/dns/win32util.py
index 14fc17e0..deebc818 100644
--- a/dns/win32util.py
+++ b/dns/win32util.py
@@ -45,13 +45,14 @@ if sys.platform == "win32":
                 try:
                     system = wmi.WMI()
                     for interface in system.Win32_NetworkAdapterConfiguration():
-                        if interface.IPEnabled:
+                        if interface.IPEnabled and interface.DNSDomain:
                             self.info.domain = _config_domain(interface.DNSDomain)
                             self.info.nameservers = list(interface.DNSServerSearchOrder)
-                            self.info.search = [
-                                dns.name.from_text(x)
-                                for x in interface.DNSDomainSuffixSearchOrder
-                            ]
+                            if interface.DNSDomainSuffixSearchOrder:
+                                self.info.search = [
+                                    dns.name.from_text(x)
+                                    for x in interface.DNSDomainSuffixSearchOrder
+                                ]
                             break
                 finally:
                     pythoncom.CoUninitialize()