From: Viktor Szakats <commit@vsz.me>
Date: Thu, 30 Jan 2025 15:38:18 +0000 (+0100)
Subject: cmake: drop `CURL_DISABLE_TESTS` option
X-Git-Tag: curl-8_13_0~402
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bf823397bad09791277e983e44e8f0edc3c089b2;p=thirdparty%2Fcurl.git

cmake: drop `CURL_DISABLE_TESTS` option

curl builds tests with CMake when explicitly building the `testdeps`
target. It's not built by default. It seems overkill to have
a curl-specific variant of this (over CMake's `BUILD_TESTING`)
to disable generating this target.

Its history also doesn't make it obvious why this was necessary,
and there was a long debate how to do it, by the time the original
submitter abandoned CMake. The option also remained uninitialized
and thus undocumented.

Let me know if I missed something.

Ref: #6036
Ref: 3a1e798009799be1e9fad30666351b66f250befb #6072
Closes #16134
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 0f42fd8f4c..764b6fcc0b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -2009,7 +2009,7 @@ set(_project_config "${_generated_dir}/${PROJECT_NAME}Config.cmake")
 set(_version_config "${_generated_dir}/${PROJECT_NAME}ConfigVersion.cmake")
 
 option(BUILD_TESTING "Build tests" ON)
-if(BUILD_TESTING AND PERL_FOUND AND NOT CURL_DISABLE_TESTS)
+if(BUILD_TESTING AND PERL_FOUND)
   set(CURL_BUILD_TESTING ON)
 else()
   set(CURL_BUILD_TESTING OFF)