From: Jouni Malinen <j@w1.fi>
Date: Tue, 7 Jan 2014 13:58:01 +0000 (+0200)
Subject: bsd: Fix NULL pointer dereference on error path
X-Git-Tag: hostap_2_1~156
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bfdc2a3172567dc7a77920557cbdb64d55d471bc;p=thirdparty%2Fhostap.git

bsd: Fix NULL pointer dereference on error path

The error path in bsd_init() on struct bsd_driver_data allocation was
jumping to location where drv is dereferenced. That will crash and it is
easier to just return from the function since no cleanup steps are
needed in this case.

Signed-hostap: Jouni Malinen <j@w1.fi>
---

diff --git a/src/drivers/driver_bsd.c b/src/drivers/driver_bsd.c
index 097e7d670..71c9ce917 100644
--- a/src/drivers/driver_bsd.c
+++ b/src/drivers/driver_bsd.c
@@ -857,8 +857,8 @@ bsd_init(struct hostapd_data *hapd, struct wpa_init_params *params)
 
 	drv = os_zalloc(sizeof(struct bsd_driver_data));
 	if (drv == NULL) {
-		printf("Could not allocate memory for bsd driver data\n");
-		goto bad;
+		wpa_printf(MSG_ERROR, "Could not allocate memory for bsd driver data");
+		return NULL;
 	}
 
 	drv->event_buf_len = rtbuf_len();