From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Tue, 12 Aug 2025 13:31:16 +0000 (+0100)
Subject: spi: ich: Do not use uninitialised value
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c01280b62c44e2a6be57440939f1912e60a7d5ec;p=thirdparty%2Fu-boot.git

spi: ich: Do not use uninitialised value

In ich_spi_exec_op_swseq the variable with_address is only assigned a
value in the case of op->addr.nbytes being non-zero.
Initialise with_address to zero. so that it is always valid.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---

diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c
index 2264ca83d66..733ff8ac777 100644
--- a/drivers/spi/ich.c
+++ b/drivers/spi/ich.c
@@ -256,7 +256,7 @@ static int ich_spi_exec_op_swseq(struct spi_slave *slave,
 	struct ich_spi_priv *ctlr = dev_get_priv(bus);
 	uint16_t control;
 	int16_t opcode_index;
-	int with_address;
+	int with_address = 0;
 	int status;
 	struct spi_trans *trans = &ctlr->trans;
 	bool lock = spi_lock_status(plat, ctlr->base);