From: Michal 'vorner' Vaner <michal.vaner@nic.cz>
Date: Tue, 4 Sep 2012 10:37:35 +0000 (+0200)
Subject: Disable broken test
X-Git-Tag: trac2402_base~79^2~19
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c0128e80648ec83fb9f4e3cbf3bb7bba2ef0bbb5;p=thirdparty%2Fkea.git

Disable broken test

The test may be broken by design. In such case, it should be removed.
But it is left there for now, maybe it's just broken implementation and
someone (the reviewer?) may have an idea how to fix it.
---

diff --git a/src/lib/util/threads/tests/lock_unittest.cc b/src/lib/util/threads/tests/lock_unittest.cc
index c2755cf127..19c1074561 100644
--- a/src/lib/util/threads/tests/lock_unittest.cc
+++ b/src/lib/util/threads/tests/lock_unittest.cc
@@ -46,13 +46,17 @@ TEST(MutexTest, lockMultiple) {
 }
 
 // Destroying a locked mutex is a bad idea as well
-TEST(MutexTest, destroyLocked) {
+//
+// FIXME: The test is disabled, since it screws something up in the VM (other
+// tests fail then with rather cryptic messages, memory dumps and stuff).
+// Any idea how to make the test work and reasonably safe?
+TEST(MutexTest, DISABLED_destroyLocked) {
     // TODO: This probably won't work for non-debug mutexes. Disable on non-debug
     // compilation.
     Mutex* mutex = new Mutex;
-    Mutex::Locker* locker = new Mutex::Locker(*mutex);
+    new Mutex::Locker(*mutex);
     EXPECT_THROW(delete mutex, isc::InvalidOperation);
-    // Note: This maybe leaks the locker. But this is a test for development aid
+    // Note: This leaks the locker. But this is a test for development aid
     // exception. The exception won't happen in normal build anyway and seeing
     // it means there's a bug. And we can't delete the locker now, since it
     // would access uninitialized memory.