From: Nick Mathewson <nickm@torproject.org>
Date: Sun, 11 Apr 2004 17:07:45 +0000 (+0000)
Subject: Cosmetic patch for arma's fix for The Bug: Don't set the state to
X-Git-Tag: tor-0.0.6incompat-merged~54
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c024745bd4a207bf68d80c1527029d2ca3a8732e;p=thirdparty%2Ftor.git

Cosmetic patch for arma's fix for The Bug: Don't set the state to
RESOLVEFAILED if the resolve didn't fail; set it to CONNECTING
instead.


svn:r1590
---

diff --git a/src/or/dns.c b/src/or/dns.c
index fad3af1a52..cfa3956109 100644
--- a/src/or/dns.c
+++ b/src/or/dns.c
@@ -378,14 +378,16 @@ static void dns_found_answer(char *address, uint32_t addr, char outcome) {
     assert_connection_ok(pend->conn,time(NULL));
     pend->conn->addr = resolve->addr;
 
-    /* prevent double-remove. (this may get changed below.) */
-    pend->conn->state = EXIT_CONN_STATE_RESOLVEFAILED;
 
     if(resolve->state == CACHE_STATE_FAILED) {
       pendconn = pend->conn; /* don't pass complex things to the
                                 connection_mark_for_close macro */
+      /* prevent double-remove. */
+      pend->conn->state = EXIT_CONN_STATE_RESOLVEFAILED;
       connection_mark_for_close(pendconn, END_STREAM_REASON_RESOLVEFAILED);
     } else {
+      /* prevent double-remove. */
+      pend->conn->state = EXIT_CONN_STATE_CONNECTING;
       connection_exit_connect(pend->conn);
     }
     resolve->pending_connections = pend->next;