From: Alexander Holler Date: Tue, 14 Aug 2012 07:11:09 +0000 (+0200) Subject: video/udlfb: fix line counting in fb_write X-Git-Tag: v3.2.33~72 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c03970223182c35eeff66d4ff319bf2d97f4efc3;p=thirdparty%2Fkernel%2Fstable.git video/udlfb: fix line counting in fb_write commit b8c4321f3d194469007f5f5f2b34ec278c264a04 upstream. Line 0 and 1 were both written to line 0 (on the display) and all subsequent lines had an offset of -1. The result was that the last line on the display was never overwritten by writes to /dev/fbN. Signed-off-by: Alexander Holler Acked-by: Bernie Thompson Signed-off-by: Florian Tobias Schandinat Signed-off-by: Ben Hutchings --- diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c index 41746bbe5c0e5..cb5988f15d032 100644 --- a/drivers/video/udlfb.c +++ b/drivers/video/udlfb.c @@ -646,7 +646,7 @@ static ssize_t dlfb_ops_write(struct fb_info *info, const char __user *buf, result = fb_sys_write(info, buf, count, ppos); if (result > 0) { - int start = max((int)(offset / info->fix.line_length) - 1, 0); + int start = max((int)(offset / info->fix.line_length), 0); int lines = min((u32)((result / info->fix.line_length) + 1), (u32)info->var.yres);