From: Antoine Pitrou Date: Sun, 8 Apr 2012 23:37:19 +0000 (+0200) Subject: Fix the patch for issue #7978: select() raises select.error before 3.3, not OSError. X-Git-Tag: v3.3.0a3~283^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c0aa9eeb90204b8a67a610180c003c182d1691aa;p=thirdparty%2FPython%2Fcpython.git Fix the patch for issue #7978: select() raises select.error before 3.3, not OSError. --- diff --git a/Lib/socketserver.py b/Lib/socketserver.py index c8a8db1950ee..adf9f38ead8f 100644 --- a/Lib/socketserver.py +++ b/Lib/socketserver.py @@ -153,8 +153,8 @@ def _eintr_retry(func, *args): while True: try: return func(*args) - except OSError as e: - if e.errno != errno.EINTR: + except (OSError, select.error) as e: + if e.args[0] != errno.EINTR: raise class BaseServer: diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py index 353f8ff3d4d2..ca23301cd1f8 100644 --- a/Lib/test/test_socketserver.py +++ b/Lib/test/test_socketserver.py @@ -244,7 +244,7 @@ class SocketServerTest(unittest.TestCase): self.called += 1 if self.called == 1: # raise the exception on first call - raise OSError(errno.EINTR, os.strerror(errno.EINTR)) + raise select.error(errno.EINTR, os.strerror(errno.EINTR)) else: # Return real select value for consecutive calls return old_select(*args)