From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Mon, 6 Jan 2025 17:54:15 +0000 (+0000)
Subject: sstate: Ensure errors cause task failure
X-Git-Tag: yocto-5.2~848
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c1491ef7afc8722927c568b0ac0ddbbc84837ca3;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

sstate: Ensure errors cause task failure

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/classes-global/sstate.bbclass b/meta/classes-global/sstate.bbclass
index decfb5adefd..2c259a66579 100644
--- a/meta/classes-global/sstate.bbclass
+++ b/meta/classes-global/sstate.bbclass
@@ -646,6 +646,7 @@ def sstate_package(ss, d):
     d.setVar("SSTATE_CURRTASK", ss['task'])
     bb.utils.remove(sstatebuild, recurse=True)
     bb.utils.mkdirhier(sstatebuild)
+    exit = False
     for state in ss['dirs']:
         if not os.path.exists(state[1]):
             continue
@@ -664,8 +665,11 @@ def sstate_package(ss, d):
                 if not link.startswith(tmpdir):
                     continue
                 bb.error("sstate found an absolute path symlink %s pointing at %s. Please replace this with a relative link." % (srcpath, link))
+                exit = True
         bb.debug(2, "Preparing tree %s for packaging at %s" % (state[1], sstatebuild + state[0]))
         bb.utils.rename(state[1], sstatebuild + state[0])
+    if exit:
+        bb.fatal("Failing task due to absolute path symlinks")
 
     workdir = d.getVar('WORKDIR')
     sharedworkdir = os.path.join(d.getVar('TMPDIR'), "work-shared")