From: Noel Power Date: Mon, 8 Jul 2019 12:12:59 +0000 (+0000) Subject: nsswitch/libwbclient: clang Fix Potential leak of memory X-Git-Tag: talloc-2.3.0~119 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c19f1c9a3e7fc103754703dff11aa3b63b1edb95;p=thirdparty%2Fsamba.git nsswitch/libwbclient: clang Fix Potential leak of memory Fixes: nsswitch/libwbclient/wbc_sid.c:848:2: warning: Potential leak of memory pointed to by 'extra_data' free(extra_data); ^ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/nsswitch/libwbclient/wbc_sid.c b/nsswitch/libwbclient/wbc_sid.c index cec7b519bfd..aab96cf9188 100644 --- a/nsswitch/libwbclient/wbc_sid.c +++ b/nsswitch/libwbclient/wbc_sid.c @@ -792,12 +792,14 @@ wbcErr wbcCtxGetSidAliases(struct wbcContext *ctx, sid_len = wbcSidToStringBuf(&sids[i], sid_str, sizeof(sid_str)); if (buflen < extra_data_len + sid_len + 2) { + char * tmp_data = NULL; buflen *= 2; - extra_data = (char *)realloc(extra_data, buflen); - if (!extra_data) { + tmp_data = (char *)realloc(extra_data, buflen); + if (!tmp_data) { wbc_status = WBC_ERR_NO_MEMORY; BAIL_ON_WBC_ERROR(wbc_status); } + extra_data = tmp_data; } strncpy(&extra_data[extra_data_len], sid_str,