From: neonene <53406459+neonene@users.noreply.github.com>
Date: Wed, 17 Apr 2024 20:43:29 +0000 (+0900)
Subject: gh-117613: Argument Clinic: disallow defining class parameter at module level (#117950)
X-Git-Tag: v3.13.0b1~365
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c1d7147c820545bb0a97a072fdba82154fd97ab6;p=thirdparty%2FPython%2Fcpython.git

gh-117613: Argument Clinic: disallow defining class parameter at module level (#117950)
---

diff --git a/Lib/test/test_clinic.py b/Lib/test/test_clinic.py
index 43b629f59f03..d9e4ce280c68 100644
--- a/Lib/test/test_clinic.py
+++ b/Lib/test/test_clinic.py
@@ -2518,6 +2518,15 @@ class ClinicParserTest(TestCase):
         p = function.parameters['cls']
         self.assertEqual(p.kind, inspect.Parameter.POSITIONAL_ONLY)
 
+    def test_disallow_defining_class_at_module_level(self):
+        err = "A 'defining_class' parameter cannot be defined at module level."
+        block = """
+            module m
+            m.func
+                cls: defining_class
+        """
+        self.expect_failure(block, err, lineno=2)
+
 
 class ClinicExternalTest(TestCase):
     maxDiff = None
diff --git a/Tools/clinic/libclinic/dsl_parser.py b/Tools/clinic/libclinic/dsl_parser.py
index 56c6dca3db3d..cb18374cf07e 100644
--- a/Tools/clinic/libclinic/dsl_parser.py
+++ b/Tools/clinic/libclinic/dsl_parser.py
@@ -1102,6 +1102,8 @@ class DSLParser:
                     fail("A 'defining_class' parameter cannot have a default value.")
                 if self.group:
                     fail("A 'defining_class' parameter cannot be in an optional group.")
+                if self.function.cls is None:
+                    fail("A 'defining_class' parameter cannot be defined at module level.")
                 kind = inspect.Parameter.POSITIONAL_ONLY
             else:
                 fail("A 'defining_class' parameter, if specified, must either "