From: Victor Stinner <victor.stinner@gmail.com>
Date: Tue, 14 Jun 2016 14:42:59 +0000 (+0200)
Subject: subprocess: enhance ResourceWarning message
X-Git-Tag: v3.6.0a3~145
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c206f1eb1c4d5ac397ce7059e56bb201e44a0ce9;p=thirdparty%2FPython%2Fcpython.git

subprocess: enhance ResourceWarning message

* Add the process identifier to the warning message
* Add also a comment to explain the issue
---

diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 98f339ee5c22..3dea089e6a75 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -993,7 +993,6 @@ class Popen(object):
 
             raise
 
-
     def _translate_newlines(self, data, encoding):
         data = data.decode(encoding)
         return data.replace("\r\n", "\n").replace("\r", "\n")
@@ -1018,8 +1017,10 @@ class Popen(object):
             # We didn't get to successfully create a child process.
             return
         if self.returncode is None:
-            warnings.warn("running subprocess %r" % self, ResourceWarning,
-                          source=self)
+            # Not reading subprocess exit status creates a zombi process which
+            # is only destroyed at the parent python process exit
+            warnings.warn("subprocess %s is still running" % self.pid,
+                          ResourceWarning, source=self)
         # In case the child hasn't been waited on, check if it's done.
         self._internal_poll(_deadstate=_maxsize)
         if self.returncode is None and _active is not None: