From: Tom Krizek <tkrizek@isc.org>
Date: Tue, 7 Jun 2022 15:27:25 +0000 (+0200)
Subject: Move pylint CI job to precheck stage
X-Git-Tag: v9.19.3~61^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c2275d9f6edcb8ff2de386c73eb17af379b25c2a;p=thirdparty%2Fbind9.git

Move pylint CI job to precheck stage

Historically, some *.py files were generated, so Python checks required
running ./configure beforehand. This is no longer the case since v9_18,
so let's run the job ASAP without the unnecessary extra dependency on
autoconf job.
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 2ebf280988e..75b68b687c9 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -460,6 +460,14 @@ coccinelle:
     - util/check-cocci
     - if test "$(git status --porcelain | grep -Ev '\?\?' | wc -l)" -gt "0"; then git status --short; exit 1; fi
 
+pylint:
+  <<: *precheck_job
+  needs: []
+  script:
+    - pylint --rcfile $CI_PROJECT_DIR/.pylintrc $(git ls-files '*.py' | grep -vE '(ans\.py|dangerfile\.py|^bin/tests/system/)')
+      # Ignore Pylint wrong-import-position error in system test to enable use of pytest.importorskip
+    - pylint --rcfile $CI_PROJECT_DIR/.pylintrc --disable=wrong-import-position $(git ls-files 'bin/tests/system/*.py' | grep -vE 'ans\.py')
+
 reuse:
   <<: *precheck_job
   needs: []
@@ -480,19 +488,6 @@ danger:
     variables:
       - $DANGER_GITLAB_API_TOKEN
 
-pylint:
-  <<: *default_triggering_rules
-  <<: *base_image
-  stage: postcheck
-  needs:
-    - job: autoreconf
-      artifacts: true
-  script:
-    - *configure
-    - pylint --rcfile $CI_PROJECT_DIR/.pylintrc $(git ls-files '*.py' | grep -vE '(ans\.py|dangerfile\.py|^bin/tests/system/)')
-      # Ignore Pylint wrong-import-position error in system test to enable use of pytest.importorskip
-    - pylint --rcfile $CI_PROJECT_DIR/.pylintrc --disable=wrong-import-position $(git ls-files 'bin/tests/system/*.py' | grep -vE 'ans\.py')
-
 tarball-create:
   stage: precheck
   <<: *base_image