From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 18 Jun 2024 12:18:17 +0000 (+0200)
Subject: Revert "TMP-REPRODUCE: vfs_recycle: demonstrate memory corruption in recycle_unlink_i... 
X-Git-Tag: tdb-1.4.11~341
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c229a84b449b8ba326ee0f6f702d91f101b99ee4;p=thirdparty%2Fsamba.git

Revert "TMP-REPRODUCE: vfs_recycle: demonstrate memory corruption in recycle_unlink_internal()"

This was only added to demonstrate the problem more reliable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15659

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Noel Power <noel.power@suse.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c
index f318e0ab1db..7827dcd638d 100644
--- a/source3/modules/vfs_recycle.c
+++ b/source3/modules/vfs_recycle.c
@@ -476,8 +476,6 @@ static int recycle_unlink_internal(vfs_handle_struct *handle,
 	int rc = -1;
 	struct recycle_config_data *config = NULL;
 
-	reload_services(NULL, NULL, false);
-
 	SMB_VFS_HANDLE_GET_DATA(handle,
 				config,
 				struct recycle_config_data,