From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Mon, 24 Mar 2025 21:05:55 +0000 (+0100) Subject: [3.13] gh-131677: Fix flaky test_lru_cache_threaded3 (gh-131679) (gh-131692) X-Git-Tag: v3.13.3~84 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c22eef44d8b1d2828108b49a735359917ad1da79;p=thirdparty%2FPython%2Fcpython.git [3.13] gh-131677: Fix flaky test_lru_cache_threaded3 (gh-131679) (gh-131692) The call to `with self.subTest(...)` was not thread-safe. (cherry picked from commit a1232459860235f4fb7896cc95966d87a51cbe32) Co-authored-by: Sam Gross --- diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py index 544107e5a1c1..96001a943f03 100644 --- a/Lib/test/test_functools.py +++ b/Lib/test/test_functools.py @@ -1782,8 +1782,7 @@ class TestLRU: time.sleep(.01) return 3 * x def test(i, x): - with self.subTest(thread=i): - self.assertEqual(f(x), 3 * x, i) + self.assertEqual(f(x), 3 * x, i) threads = [threading.Thread(target=test, args=(i, v)) for i, v in enumerate([1, 2, 2, 3, 2])] with threading_helper.start_threads(threads):