From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 18 Apr 2009 01:39:58 +0000 (+1200)
Subject: Regression Fix: ident open failure: Address already in use
X-Git-Tag: SQUID_3_2_0_1~1057
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c26c5e627c50535959c82d7d9854042d33789fa7;p=thirdparty%2Fsquid.git

Regression Fix: ident open failure: Address already in use

Alterations in 3.1 caused the ident port opening to attept binding 3128
which was already opened by Squid.

This returns to the previous random port selection.
---

diff --git a/src/ident.cc b/src/ident.cc
index f8d942344d..061cb6b20a 100644
--- a/src/ident.cc
+++ b/src/ident.cc
@@ -220,9 +220,12 @@ identStart(IpAddress &me, IpAddress &my_peer, IDCB * callback, void *data)
         return;
     }
 
+    IpAddress addr = me;
+    addr.SetPort(0); // NP: use random port for secure outbound to IDENT_PORT
+
     fd = comm_open_listener(SOCK_STREAM,
                    IPPROTO_TCP,
-                   me,
+                   addr,
                    COMM_NONBLOCKING,
                    "ident");