From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 11 Oct 2023 14:59:24 +0000 (+0200)
Subject: varlink: don't bother replying about validation errors on method calls with 'oneway... 
X-Git-Tag: v255-rc1~267^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c270fc448ea82ff1aa3af08f15fe7aa39fddb52e;p=thirdparty%2Fsystemd.git

varlink: don't bother replying about validation errors on method calls with 'oneway' set
---

diff --git a/src/shared/varlink.c b/src/shared/varlink.c
index 8eeac4a49fd..8f643e27b0f 100644
--- a/src/shared/varlink.c
+++ b/src/shared/varlink.c
@@ -1314,7 +1314,12 @@ static int varlink_dispatch_method(Varlink *v) {
                         r = varlink_idl_validate_method_call(v->current_method, parameters, &bad_field);
                         if (r < 0) {
                                 log_debug_errno(r, "Parameters for method %s() didn't pass validation on field '%s': %m", method, strna(bad_field));
-                                r = varlink_errorb(v, VARLINK_ERROR_INVALID_PARAMETER, JSON_BUILD_OBJECT(JSON_BUILD_PAIR_STRING("parameter", bad_field)));
+
+                                if (!FLAGS_SET(flags, VARLINK_METHOD_ONEWAY)) {
+                                        r = varlink_errorb(v, VARLINK_ERROR_INVALID_PARAMETER, JSON_BUILD_OBJECT(JSON_BUILD_PAIR_STRING("parameter", bad_field)));
+                                        if (r < 0)
+                                                return r;
+                                }
                                 invalid = true;
                         }
                 }