From: Russell Bryant <russell@russellbryant.com>
Date: Fri, 12 Oct 2007 15:40:35 +0000 (+0000)
Subject: Fix the potential use of an uninitialized buffer in a log message.
X-Git-Tag: 1.4.14~168
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c27db984f96da7ec6c88929be3607a516fc05855;p=thirdparty%2Fasterisk.git

Fix the potential use of an uninitialized buffer in a log message.

(closes issue #10958)
Reported by: dimas
Patches:
      realtime.patch uploaded by dimas (license 88)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85515 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/pbx/pbx_realtime.c b/pbx/pbx_realtime.c
index d1011fe8eb..b9be0d456f 100644
--- a/pbx/pbx_realtime.c
+++ b/pbx/pbx_realtime.c
@@ -178,12 +178,12 @@ static int realtime_exec(struct ast_channel *chan, const char *context, const ch
 
 	if (var) {
 		char *tmp="";
-		char app[256];
+		char *app = NULL;
 		struct ast_variable *v;
 
 		for (v = var; v ; v = v->next) {
 			if (!strcasecmp(v->name, "app"))
-				ast_copy_string(app, v->value, sizeof(app));
+				app = ast_strdupa(v->value);
 			else if (!strcasecmp(v->name, "appdata"))
 				tmp = ast_strdupa(v->value);
 		}
@@ -216,6 +216,8 @@ static int realtime_exec(struct ast_channel *chan, const char *context, const ch
 				res = pbx_exec(chan, a, appdata);
 			} else
 				ast_log(LOG_NOTICE, "No such application '%s' for extension '%s' in context '%s'\n", app, exten, context);
+		} else {
+			ast_log(LOG_WARNING, "No application specified for realtime extension '%s' in context '%s'\n", exten, context);
 		}
 	}
 	return res;