From: Tony Locke <tlocke@tlocke.org.uk>
Date: Sat, 26 Jul 2014 15:19:09 +0000 (+0100)
Subject: With pg8000-1.9.13 passes engine/test_reconnect
X-Git-Tag: rel_1_0_0b1~216^2~9^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c2a00153f1a8d4591de6ebe4f75e8595d7193226;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

With pg8000-1.9.13 passes engine/test_reconnect

The pg8000 dialect checks the text of the exception to determine if the
connection is closed. I'd (recklessly!) changed the text of the
exception in a recent version of the pg8000 driver adding capitalization
and a full stop. I've changed it back now so all works.
---

diff --git a/test/requirements.py b/test/requirements.py
index e8705d1452..bf9b8f5263 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -366,16 +366,6 @@ class DefaultRequirements(SuiteRequirements):
             no_support("postgresql+pg8000", "not supported and/or hangs")
             ])
 
-    @property
-    def graceful_disconnects(self):
-        """Target driver must raise a DBAPI-level exception, such as
-        InterfaceError, when the underlying connection has been closed
-        and the execute() method is called.
-        """
-        return fails_on(
-                    "postgresql+pg8000", "Driver crashes"
-                )
-
     @property
     def views(self):
         """Target database must support VIEWs."""