From: Michal Nowak <mnowak@isc.org>
Date: Mon, 1 Jun 2026 20:56:50 +0000 (+0200)
Subject: fix: ci: Disable dnstap in reproducible-build CI job
X-Git-Tag: v9.21.23~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c2b36b74af15ed6c8c5dc03c90cc6a2085fcbd7e;p=thirdparty%2Fbind9.git

fix: ci: Disable dnstap in reproducible-build CI job

Commit 515ff3763c ("Simplify reproducible-build CI job") dropped the
-Ddnstap=disabled option from the "meson reprotest" invocation, which
re-introduced a known reproducibility failure:

    Build differences detected
    File contents differ: buildrepro/libdnstap.a

The job builds with CFLAGS=${CFLAGS_COMMON}, which enables LTO with
-ffat-lto-objects. Fat LTO objects embed GIMPLE bytecode keyed by a
per-compilation random LTO hash, so they are not reproducible run to
run. libdnstap.a is the only static archive in the build, and meson
treats every .a as a final, checked artifact, so the two reprotest
builds disagree on its contents. The shared libraries are unaffected
because final LTO linking re-emits and strips the bytecode.

Restore the -Ddnstap=disabled workaround, along with a comment
explaining the instability. The unrelated -Ddoc=disabled and
-Doptimization=1 options are left dropped, as they were only build-time
speedups and not related to reproducibility.

Assisted-by: Claude:claude-opus-4-8

Merge branch 'mnowak/reprotest-disable-dnstap-lto' into 'main'

See merge request isc-projects/bind9!12161
---

c2b36b74af15ed6c8c5dc03c90cc6a2085fcbd7e