From: Alexander Stephan <alexander.stephan@sap.com>
Date: Thu, 11 Dec 2025 10:00:11 +0000 (+0000)
Subject: MINOR: mworker/cli: only keep positive PIDs in proc_list
X-Git-Tag: v3.4-dev2~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c30eeb29677aa098a4a3d2cc449681b40e465475;p=thirdparty%2Fhaproxy.git

MINOR: mworker/cli: only keep positive PIDs in proc_list

Change mworker_env_to_proc_list() to if (child->pid > 0) before
LIST_APPEND, avoiding invalid PIDs (0/-1) in the process list.
This has no functional impact beyond stricter validation and it aligns
with existing kill safeguards.
---

diff --git a/src/mworker.c b/src/mworker.c
index 6aed15f3f..2ff415a8b 100644
--- a/src/mworker.c
+++ b/src/mworker.c
@@ -223,7 +223,7 @@ int mworker_env_to_proc_list()
 				child->version = strdup(subtoken+8);
 			}
 		}
-		if (child->pid) {
+		if (child->pid > 0) {
 			LIST_APPEND(&proc_list, &child->list);
 		} else {
 			mworker_free_child(child);
@@ -909,6 +909,7 @@ static int cli_io_handler_show_proc(struct appctx *appctx)
 	/* dump complete */
 	return 1;
 }
+
 /* reload the master process */
 static int cli_parse_show_proc(char **args, char *payload, struct appctx *appctx, void *private)
 {