From: Volker Lendecke <vl@samba.org>
Date: Fri, 30 Mar 2018 16:37:49 +0000 (-0500)
Subject: smbd: Fix CID 240676 Dereference after null check
X-Git-Tag: talloc-2.1.13~61
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c31e5371bf3334964c078c963de7b5db7236ff35;p=thirdparty%2Fsamba.git

smbd: Fix CID 240676 Dereference after null check

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 643e074f399..3c24d76a089 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -5079,6 +5079,13 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 	if (lease != NULL) {
 		uint16_t epoch = lease->lease_epoch;
 		uint16_t version = lease->lease_version;
+
+		if (req == NULL) {
+			DBG_WARNING("Got lease on internal open\n");
+			status = NT_STATUS_INTERNAL_ERROR;
+			goto fail;
+		}
+
 		status = lease_match(conn,
 				req,
 				&lease->lease_key,