From: Suman Anna <s-anna@ti.com>
Date: Fri, 14 May 2021 16:12:43 +0000 (-0500)
Subject: crypto: sa2ul - Fix pm_runtime enable in sa_ul_probe()
X-Git-Tag: v5.10.50~369
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c3285441b4cd9b7ab759dfcb3164e4825656326c;p=thirdparty%2Fkernel%2Fstable.git

crypto: sa2ul - Fix pm_runtime enable in sa_ul_probe()

[ Upstream commit 5c8552325e013cbdabc443cd1f1b4d03c4a2e64e ]

The pm_runtime APIs added first in commit 7694b6ca649f ("crypto: sa2ul -
Add crypto driver") are not unwound properly and was fixed up partially
in commit 13343badae09 ("crypto: sa2ul - Fix PM reference leak in
sa_ul_probe()"). This fixed up the pm_runtime usage count but not the
state. Fix this properly.

Fixes: 13343badae09 ("crypto: sa2ul - Fix PM reference leak in sa_ul_probe()")
Signed-off-by: Suman Anna <s-anna@ti.com>
Reviewed-by: Tero Kristo <kristo@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index fdc844363f021..f15fc1fb37079 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -2356,6 +2356,7 @@ static int sa_ul_probe(struct platform_device *pdev)
 	if (ret < 0) {
 		dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__,
 			ret);
+		pm_runtime_disable(dev);
 		return ret;
 	}