From: Greg Kroah-Hartman Date: Tue, 1 Oct 2024 14:06:52 +0000 (+0200) Subject: 4.19-stable patches X-Git-Tag: v6.6.54~56 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c356750ee417cac6435a08dae5e3ec0c6b3780a7;p=thirdparty%2Fkernel%2Fstable-queue.git 4.19-stable patches added patches: f2fs-avoid-potential-int-overflow-in-sanity_check_area_boundary.patch f2fs-prevent-possible-int-overflow-in-dir_block_index.patch fs-fix-file_set_fowner-lsm-hook-inconsistencies.patch nfs-fix-memory-leak-in-error-path-of-nfs4_do_reclaim.patch vfs-fix-race-between-evice_inodes-and-find_inode-iput.patch --- diff --git a/queue-4.19/f2fs-avoid-potential-int-overflow-in-sanity_check_area_boundary.patch b/queue-4.19/f2fs-avoid-potential-int-overflow-in-sanity_check_area_boundary.patch new file mode 100644 index 00000000000..014bb231805 --- /dev/null +++ b/queue-4.19/f2fs-avoid-potential-int-overflow-in-sanity_check_area_boundary.patch @@ -0,0 +1,43 @@ +From 50438dbc483ca6a133d2bce9d5d6747bcee38371 Mon Sep 17 00:00:00 2001 +From: Nikita Zhandarovich +Date: Wed, 24 Jul 2024 10:51:58 -0700 +Subject: f2fs: avoid potential int overflow in sanity_check_area_boundary() + +From: Nikita Zhandarovich + +commit 50438dbc483ca6a133d2bce9d5d6747bcee38371 upstream. + +While calculating the end addresses of main area and segment 0, u32 +may be not enough to hold the result without the danger of int +overflow. + +Just in case, play it safe and cast one of the operands to a +wider type (u64). + +Found by Linux Verification Center (linuxtesting.org) with static +analysis tool SVACE. + +Fixes: fd694733d523 ("f2fs: cover large section in sanity check of super") +Cc: stable@vger.kernel.org +Signed-off-by: Nikita Zhandarovich +Reviewed-by: Chao Yu +Signed-off-by: Jaegeuk Kim +Signed-off-by: Greg Kroah-Hartman +--- + fs/f2fs/super.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- a/fs/f2fs/super.c ++++ b/fs/f2fs/super.c +@@ -2116,9 +2116,9 @@ static inline bool sanity_check_area_bou + u32 segment_count = le32_to_cpu(raw_super->segment_count); + u32 log_blocks_per_seg = le32_to_cpu(raw_super->log_blocks_per_seg); + u64 main_end_blkaddr = main_blkaddr + +- (segment_count_main << log_blocks_per_seg); ++ ((u64)segment_count_main << log_blocks_per_seg); + u64 seg_end_blkaddr = segment0_blkaddr + +- (segment_count << log_blocks_per_seg); ++ ((u64)segment_count << log_blocks_per_seg); + + if (segment0_blkaddr != cp_blkaddr) { + f2fs_msg(sb, KERN_INFO, diff --git a/queue-4.19/f2fs-prevent-possible-int-overflow-in-dir_block_index.patch b/queue-4.19/f2fs-prevent-possible-int-overflow-in-dir_block_index.patch new file mode 100644 index 00000000000..4c711fa271d --- /dev/null +++ b/queue-4.19/f2fs-prevent-possible-int-overflow-in-dir_block_index.patch @@ -0,0 +1,42 @@ +From 47f268f33dff4a5e31541a990dc09f116f80e61c Mon Sep 17 00:00:00 2001 +From: Nikita Zhandarovich +Date: Wed, 24 Jul 2024 10:05:44 -0700 +Subject: f2fs: prevent possible int overflow in dir_block_index() + +From: Nikita Zhandarovich + +commit 47f268f33dff4a5e31541a990dc09f116f80e61c upstream. + +The result of multiplication between values derived from functions +dir_buckets() and bucket_blocks() *could* technically reach +2^30 * 2^2 = 2^32. + +While unlikely to happen, it is prudent to ensure that it will not +lead to integer overflow. Thus, use mul_u32_u32() as it's more +appropriate to mitigate the issue. + +Found by Linux Verification Center (linuxtesting.org) with static +analysis tool SVACE. + +Fixes: 3843154598a0 ("f2fs: introduce large directory support") +Cc: stable@vger.kernel.org +Signed-off-by: Nikita Zhandarovich +Reviewed-by: Chao Yu +Signed-off-by: Jaegeuk Kim +Signed-off-by: Greg Kroah-Hartman +--- + fs/f2fs/dir.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/fs/f2fs/dir.c ++++ b/fs/f2fs/dir.c +@@ -79,7 +79,8 @@ static unsigned long dir_block_index(uns + unsigned long bidx = 0; + + for (i = 0; i < level; i++) +- bidx += dir_buckets(i, dir_level) * bucket_blocks(i); ++ bidx += mul_u32_u32(dir_buckets(i, dir_level), ++ bucket_blocks(i)); + bidx += idx * bucket_blocks(level); + return bidx; + } diff --git a/queue-4.19/fs-fix-file_set_fowner-lsm-hook-inconsistencies.patch b/queue-4.19/fs-fix-file_set_fowner-lsm-hook-inconsistencies.patch new file mode 100644 index 00000000000..7e1437d0589 --- /dev/null +++ b/queue-4.19/fs-fix-file_set_fowner-lsm-hook-inconsistencies.patch @@ -0,0 +1,90 @@ +From 26f204380a3c182e5adf1a798db0724d6111b597 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= +Date: Wed, 21 Aug 2024 11:56:05 +0200 +Subject: fs: Fix file_set_fowner LSM hook inconsistencies +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Mickaël Salaün + +commit 26f204380a3c182e5adf1a798db0724d6111b597 upstream. + +The fcntl's F_SETOWN command sets the process that handle SIGIO/SIGURG +for the related file descriptor. Before this change, the +file_set_fowner LSM hook was always called, ignoring the VFS logic which +may not actually change the process that handles SIGIO (e.g. TUN, TTY, +dnotify), nor update the related UID/EUID. + +Moreover, because security_file_set_fowner() was called without lock +(e.g. f_owner.lock), concurrent F_SETOWN commands could result to a race +condition and inconsistent LSM states (e.g. SELinux's fown_sid) compared +to struct fown_struct's UID/EUID. + +This change makes sure the LSM states are always in sync with the VFS +state by moving the security_file_set_fowner() call close to the +UID/EUID updates and using the same f_owner.lock . + +Rename f_modown() to __f_setown() to simplify code. + +Cc: stable@vger.kernel.org +Cc: Al Viro +Cc: Casey Schaufler +Cc: Christian Brauner +Cc: James Morris +Cc: Jann Horn +Cc: Ondrej Mosnacek +Cc: Paul Moore +Cc: Serge E. Hallyn +Cc: Stephen Smalley +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Signed-off-by: Mickaël Salaün +Signed-off-by: Paul Moore +Signed-off-by: Greg Kroah-Hartman +--- + fs/fcntl.c | 14 ++++---------- + 1 file changed, 4 insertions(+), 10 deletions(-) + +--- a/fs/fcntl.c ++++ b/fs/fcntl.c +@@ -84,8 +84,8 @@ static int setfl(int fd, struct file * f + return error; + } + +-static void f_modown(struct file *filp, struct pid *pid, enum pid_type type, +- int force) ++void __f_setown(struct file *filp, struct pid *pid, enum pid_type type, ++ int force) + { + write_lock_irq(&filp->f_owner.lock); + if (force || !filp->f_owner.pid) { +@@ -95,19 +95,13 @@ static void f_modown(struct file *filp, + + if (pid) { + const struct cred *cred = current_cred(); ++ security_file_set_fowner(filp); + filp->f_owner.uid = cred->uid; + filp->f_owner.euid = cred->euid; + } + } + write_unlock_irq(&filp->f_owner.lock); + } +- +-void __f_setown(struct file *filp, struct pid *pid, enum pid_type type, +- int force) +-{ +- security_file_set_fowner(filp); +- f_modown(filp, pid, type, force); +-} + EXPORT_SYMBOL(__f_setown); + + int f_setown(struct file *filp, unsigned long arg, int force) +@@ -143,7 +137,7 @@ EXPORT_SYMBOL(f_setown); + + void f_delown(struct file *filp) + { +- f_modown(filp, NULL, PIDTYPE_TGID, 1); ++ __f_setown(filp, NULL, PIDTYPE_TGID, 1); + } + + pid_t f_getown(struct file *filp) diff --git a/queue-4.19/nfs-fix-memory-leak-in-error-path-of-nfs4_do_reclaim.patch b/queue-4.19/nfs-fix-memory-leak-in-error-path-of-nfs4_do_reclaim.patch new file mode 100644 index 00000000000..73d7ba0f6f3 --- /dev/null +++ b/queue-4.19/nfs-fix-memory-leak-in-error-path-of-nfs4_do_reclaim.patch @@ -0,0 +1,35 @@ +From 8f6a7c9467eaf39da4c14e5474e46190ab3fb529 Mon Sep 17 00:00:00 2001 +From: Li Lingfeng +Date: Wed, 4 Sep 2024 20:34:57 +0800 +Subject: nfs: fix memory leak in error path of nfs4_do_reclaim + +From: Li Lingfeng + +commit 8f6a7c9467eaf39da4c14e5474e46190ab3fb529 upstream. + +Commit c77e22834ae9 ("NFSv4: Fix a potential sleep while atomic in +nfs4_do_reclaim()") separate out the freeing of the state owners from +nfs4_purge_state_owners() and finish it outside the rcu lock. +However, the error path is omitted. As a result, the state owners in +"freeme" will not be released. +Fix it by adding freeing in the error path. + +Fixes: c77e22834ae9 ("NFSv4: Fix a potential sleep while atomic in nfs4_do_reclaim()") +Signed-off-by: Li Lingfeng +Cc: stable@vger.kernel.org # v5.3+ +Signed-off-by: Anna Schumaker +Signed-off-by: Greg Kroah-Hartman +--- + fs/nfs/nfs4state.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/fs/nfs/nfs4state.c ++++ b/fs/nfs/nfs4state.c +@@ -1892,6 +1892,7 @@ restart: + set_bit(ops->owner_flag_bit, &sp->so_flags); + nfs4_put_state_owner(sp); + status = nfs4_recovery_handle_error(clp, status); ++ nfs4_free_state_owners(&freeme); + return (status != 0) ? status : -EAGAIN; + } + diff --git a/queue-4.19/series b/queue-4.19/series index fc98b7693b6..572e6ebe796 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -119,3 +119,8 @@ tty-rp2-fix-reset-with-non-forgiving-pcie-host-bridges.patch drbd-fix-atomicity-violation-in-drbd_uuid_set_bm.patch drbd-add-null-check-for-net_conf-to-prevent-dereference-in-state-validation.patch acpi-sysfs-validate-return-type-of-_str-method.patch +f2fs-prevent-possible-int-overflow-in-dir_block_index.patch +f2fs-avoid-potential-int-overflow-in-sanity_check_area_boundary.patch +vfs-fix-race-between-evice_inodes-and-find_inode-iput.patch +fs-fix-file_set_fowner-lsm-hook-inconsistencies.patch +nfs-fix-memory-leak-in-error-path-of-nfs4_do_reclaim.patch diff --git a/queue-4.19/vfs-fix-race-between-evice_inodes-and-find_inode-iput.patch b/queue-4.19/vfs-fix-race-between-evice_inodes-and-find_inode-iput.patch new file mode 100644 index 00000000000..59a95cc7a23 --- /dev/null +++ b/queue-4.19/vfs-fix-race-between-evice_inodes-and-find_inode-iput.patch @@ -0,0 +1,91 @@ +From 88b1afbf0f6b221f6c5bb66cc80cd3b38d696687 Mon Sep 17 00:00:00 2001 +From: Julian Sun +Date: Fri, 23 Aug 2024 21:07:30 +0800 +Subject: vfs: fix race between evice_inodes() and find_inode()&iput() + +From: Julian Sun + +commit 88b1afbf0f6b221f6c5bb66cc80cd3b38d696687 upstream. + +Hi, all + +Recently I noticed a bug[1] in btrfs, after digged it into +and I believe it'a race in vfs. + +Let's assume there's a inode (ie ino 261) with i_count 1 is +called by iput(), and there's a concurrent thread calling +generic_shutdown_super(). + +cpu0: cpu1: +iput() // i_count is 1 + ->spin_lock(inode) + ->dec i_count to 0 + ->iput_final() generic_shutdown_super() + ->__inode_add_lru() ->evict_inodes() + // cause some reason[2] ->if (atomic_read(inode->i_count)) continue; + // return before // inode 261 passed the above check + // list_lru_add_obj() // and then schedule out + ->spin_unlock() +// note here: the inode 261 +// was still at sb list and hash list, +// and I_FREEING|I_WILL_FREE was not been set + +btrfs_iget() + // after some function calls + ->find_inode() + // found the above inode 261 + ->spin_lock(inode) + // check I_FREEING|I_WILL_FREE + // and passed + ->__iget() + ->spin_unlock(inode) // schedule back + ->spin_lock(inode) + // check (I_NEW|I_FREEING|I_WILL_FREE) flags, + // passed and set I_FREEING +iput() ->spin_unlock(inode) + ->spin_lock(inode) ->evict() + // dec i_count to 0 + ->iput_final() + ->spin_unlock() + ->evict() + +Now, we have two threads simultaneously evicting +the same inode, which may trigger the BUG(inode->i_state & I_CLEAR) +statement both within clear_inode() and iput(). + +To fix the bug, recheck the inode->i_count after holding i_lock. +Because in the most scenarios, the first check is valid, and +the overhead of spin_lock() can be reduced. + +If there is any misunderstanding, please let me know, thanks. + +[1]: https://lore.kernel.org/linux-btrfs/000000000000eabe1d0619c48986@google.com/ +[2]: The reason might be 1. SB_ACTIVE was removed or 2. mapping_shrinkable() +return false when I reproduced the bug. + +Reported-by: syzbot+67ba3c42bcbb4665d3ad@syzkaller.appspotmail.com +Closes: https://syzkaller.appspot.com/bug?extid=67ba3c42bcbb4665d3ad +CC: stable@vger.kernel.org +Fixes: 63997e98a3be ("split invalidate_inodes()") +Signed-off-by: Julian Sun +Link: https://lore.kernel.org/r/20240823130730.658881-1-sunjunchao2870@gmail.com +Reviewed-by: Jan Kara +Signed-off-by: Christian Brauner +Signed-off-by: Greg Kroah-Hartman +--- + fs/inode.c | 4 ++++ + 1 file changed, 4 insertions(+) + +--- a/fs/inode.c ++++ b/fs/inode.c +@@ -616,6 +616,10 @@ again: + continue; + + spin_lock(&inode->i_lock); ++ if (atomic_read(&inode->i_count)) { ++ spin_unlock(&inode->i_lock); ++ continue; ++ } + if (inode->i_state & (I_NEW | I_FREEING | I_WILL_FREE)) { + spin_unlock(&inode->i_lock); + continue;