From: Andreas Schneider <asn@samba.org>
Date: Tue, 22 Feb 2022 16:50:34 +0000 (+0100)
Subject: examples: Fix shellcheck error in VampireDriversFunctions
X-Git-Tag: talloc-2.4.0~1409
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c3823ff371fe5c605ddaa61a3c76bc233d5f1501;p=thirdparty%2Fsamba.git

examples: Fix shellcheck error in VampireDriversFunctions

examples/printing/VampireDriversFunctions:183:24: error: Double quote
array expansions to avoid re-splitting elements. [SC2068]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
---

diff --git a/examples/printing/VampireDriversFunctions b/examples/printing/VampireDriversFunctions
index 1e610700665..b06e3653214 100644
--- a/examples/printing/VampireDriversFunctions
+++ b/examples/printing/VampireDriversFunctions
@@ -180,7 +180,7 @@ echo -e " \n\
 
 function helpwithvampiredrivers()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithvampiredrivers ;
 else
 	echo "  ";
@@ -210,7 +210,7 @@ fi
 # -----------------------------------------------------------------------------
 function enumallfunctions()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithvampiredrivers ;
 else
 	echo " "
@@ -300,7 +300,7 @@ echo " "
 
 function fetchenumdrivers3listfromNThost()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithfetchenumdrivers3listfromNThost;
 else
 	echo " "
@@ -364,7 +364,7 @@ echo -e " \n\
 
 function createdrivernamelist()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithcreatedrivernamelist;
 else
 	echo " ";
@@ -454,7 +454,7 @@ echo -e " \n\
 
 function createprinterlistwithUNCnames()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithcreateprinterlistwithUNCnames ;
 else
 	[ -d ${nthost} ] || mkdir -p ${nthost};
@@ -527,7 +527,7 @@ echo -e " \n\
 
 function createmapofprinterstodrivers()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithcreatemapofprinterstodrivers ;
 else
 	echo " "
@@ -634,7 +634,7 @@ echo -e " \n\
 
 function getdrivernamelist()
 {
-if stringinstring $@ ; then
+if stringinstring help "$@"; then
 helpwithgetdrivernamelist ;
 else
 	[ -d ${nthost} ] || mkdir -p ${nthost};
@@ -695,7 +695,7 @@ echo -e " \n\
 
 function splitenumdrivers3list()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithsplitenumdrivers3list ;
 else
 	echo " "
@@ -790,7 +790,7 @@ echo -e " \n\
 
 function makesubdirsforWIN40driverlist()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithmakesubdirsforWIN40driverlist ;
 else
 	cat ${nthost}/WIN40/${nthost}-enumdrivers3list-WIN40.txt \
@@ -819,7 +819,7 @@ fi
 
 function makesubdirsforW32X86driverlist()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithvampiredrivers ;
 else
 	cat ${nthost}/W32X86/${nthost}-enumdrivers3list-NTx86.txt \
@@ -910,7 +910,7 @@ echo -e " \n\
 
 function splitWIN40fileintoindividualdriverfiles()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithmakesubdirsforWIN40driverlist ;
 else
 	echo " "
@@ -1057,7 +1057,7 @@ fi
 
 function splitW32X86fileintoindividualdriverfiles()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithmakesubdirsforWIN40driverlist ;
 else
 	echo " "
@@ -1239,7 +1239,7 @@ echo -e " \n\
 
 function fetchallW32X86driverfiles()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithfetchallW32X86driverfiles ;
 else
 	echo " "
@@ -1333,7 +1333,7 @@ echo -e " \n\
 
 function uploadallW32X86drivers()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithuploadallW32X86drivers ;
 else
 	echo " "
@@ -1469,7 +1469,7 @@ echo -e " \n\
 
 function fetchallWIN40driverfiles()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithfetchallWIN40driverfiles ;
 else
 	echo " "
@@ -1560,7 +1560,7 @@ echo -e " \n\
 }
 function uploadallWIN40drivers()
 {
-if stringinstring help $@ ; then
+if stringinstring help "$@"; then
 helpwithuploadallWIN40drivers ;
 else
 	echo " "