From: Benjamin Peterson <benjamin@python.org>
Date: Thu, 21 Jan 2016 06:23:44 +0000 (-0800)
Subject: prevent buffer overflow in get_data (closes #26171)
X-Git-Tag: v3.4.5rc1~18
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c4032da2012d75c6c358f74d8bf9ee98a7fe8ecf;p=thirdparty%2FPython%2Fcpython.git

prevent buffer overflow in get_data (closes #26171)
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 298d027564b7..5f1929d0b1d5 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@ Release date: tba
 Core and Builtins
 -----------------
 
+- Issue #26171: Fix possible integer overflow and heap corruption in
+  zipimporter.get_data().
+
 Library
 -------
 
diff --git a/Modules/zipimport.c b/Modules/zipimport.c
index 55bfb5d7cf7d..83fa8f932598 100644
--- a/Modules/zipimport.c
+++ b/Modules/zipimport.c
@@ -1111,6 +1111,11 @@ get_data(PyObject *archive, PyObject *toc_entry)
     }
     file_offset += l;           /* Start of file data */
 
+    if (data_size > LONG_MAX - 1) {
+        fclose(fp);
+        PyErr_NoMemory();
+        return NULL;
+    }
     bytes_size = compress == 0 ? data_size : data_size + 1;
     if (bytes_size == 0)
         bytes_size++;