From: Andreas Schneider <asn@samba.org>
Date: Thu, 7 Dec 2023 08:47:14 +0000 (+0100)
Subject: s3:tests: Fix smbget test
X-Git-Tag: talloc-2.4.2~358
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c46769f3f10d21ed802e17aa79ae17e345168e63;p=thirdparty%2Fsamba.git

s3:tests: Fix smbget test

Time to fix the smget share to not have `guest ok = yes` set. A new
[smbget_guest] will be used for guest only tests. This way we can
correctly test different authentication mechanisms.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15532

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 01b6c5fc38e..0e4ef168f4c 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -3597,6 +3597,10 @@ sub provision($$)
 [smbget]
 	path = $smbget_sharedir
 	comment = smb username is [%U]
+
+[smbget_guest]
+	path = $smbget_sharedir
+	comment = smb username is [%U]
 	guest ok = yes
 
 include = $aliceconfdir/%U.conf
diff --git a/source3/script/tests/test_smbget.sh b/source3/script/tests/test_smbget.sh
index 1956fc5b38e..0af28c6ff89 100755
--- a/source3/script/tests/test_smbget.sh
+++ b/source3/script/tests/test_smbget.sh
@@ -57,8 +57,8 @@ clear_download_area()
 test_singlefile_guest()
 {
 	clear_download_area
-	echo "$SMBGET --verbose --guest smb://$SERVER_IP/smbget/testfile"
-	$SMBGET --verbose --guest smb://$SERVER_IP/smbget/testfile
+	echo "$SMBGET --verbose --guest smb://$SERVER_IP/smbget_guest/testfile"
+	$SMBGET --verbose --guest smb://$SERVER_IP/smbget_guest/testfile
 	if [ $? -ne 0 ]; then
 		echo 'ERROR: RC does not match, expected: 0'
 		return 1
@@ -376,9 +376,9 @@ test_msdfs_link_upn()
 test_limit_rate()
 {
 	clear_download_area
-	echo "$SMBGET --verbose --guest --limit-rate 100 smb://$SERVER_IP/smbget/testfile"
+	echo "$SMBGET --verbose --guest --limit-rate 100 smb://$SERVER_IP/smbget_guest/testfile"
 	time_begin=$(date +%s)
-	$SMBGET --verbose --guest --limit-rate 100 smb://$SERVER_IP/smbget/testfile
+	$SMBGET --verbose --guest --limit-rate 100 smb://$SERVER_IP/smbget_guest/testfile
 	if [ $? -ne 0 ]; then
 		echo 'ERROR: RC does not match, expected: 0'
 		return 1