From: Thomas Markwalder <tmark@isc.org>
Date: Wed, 15 Dec 2021 15:47:29 +0000 (-0500)
Subject: [#2183] Added unit test for float columns
X-Git-Tag: Kea-2.1.2~169
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c48c55158ef061a9925361cabd7721a4e95b2cc8;p=thirdparty%2Fkea.git

[#2183] Added unit test for float columns

src/lib/pgsql/tests/pgsql_basics.h
src/lib/pgsql/tests/pgsql_exchange_unittest.cc
    TEST_F(PgSqlBasicsTest, floatTest)  - new test
---

diff --git a/src/lib/pgsql/tests/pgsql_basics.h b/src/lib/pgsql/tests/pgsql_basics.h
index 3ea6a9d5b3..1e0efc28ff 100644
--- a/src/lib/pgsql/tests/pgsql_basics.h
+++ b/src/lib/pgsql/tests/pgsql_basics.h
@@ -51,6 +51,7 @@ public:
         TIMESTAMP_COL,
         VARCHAR_COL,
         INET_COL,
+        FLOAT_COL,
         NUM_BASIC_COLS
     };
     /// @brief Constructor
@@ -79,6 +80,7 @@ public:
         expectedColNames_[TIMESTAMP_COL] = "timestamp_col";
         expectedColNames_[VARCHAR_COL] = "varchar_col";
         expectedColNames_[INET_COL] = "inet_col";
+        expectedColNames_[FLOAT_COL] = "float_col";
 
         destroySchema();
         createSchema();
@@ -126,7 +128,8 @@ public:
             "    text_col TEXT, "
             "    timestamp_col TIMESTAMP WITH TIME ZONE, "
             "    varchar_col VARCHAR(255), "
-            "    inet_col INET "
+            "    inet_col INET, "
+            "    float_col FLOAT "
             "); ";
 
         PgSqlResult r(PQexec(*conn_, sql));
@@ -210,7 +213,7 @@ public:
             "   id, bool_col, bytea_col, bigint_col, smallint_col, "
             "   int_col, text_col,"
             "   extract(epoch from timestamp_col)::bigint as timestamp_col,"
-            "   varchar_col, inet_col"
+            "   varchar_col, inet_col, float_col"
             " FROM basics";
 
         runSql(r, sql, PGRES_TUPLES_OK, line);
diff --git a/src/lib/pgsql/tests/pgsql_exchange_unittest.cc b/src/lib/pgsql/tests/pgsql_exchange_unittest.cc
index 8a5ff94096..906b9c8d8c 100644
--- a/src/lib/pgsql/tests/pgsql_exchange_unittest.cc
+++ b/src/lib/pgsql/tests/pgsql_exchange_unittest.cc
@@ -1026,7 +1026,7 @@ TEST(PsqlBindArray, insertString) {
 /// using INET columns.
 TEST_F(PgSqlBasicsTest, inetTest4) {
     // Create a prepared statement for inserting a SMALLINT
-    const char* st_name = "smallint_insert";
+    const char* st_name = "inet_insert";
     PgSqlTaggedStatement statement[] = {
         { 1, { OID_TEXT }, st_name,
           "INSERT INTO BASICS (inet_col) values (cast($1 as inet))" },
@@ -1095,7 +1095,7 @@ TEST_F(PgSqlBasicsTest, inetTest4) {
 /// using INET columns.
 TEST_F(PgSqlBasicsTest, inetTest6) {
     // Create a prepared statement for inserting a SMALLINT
-    const char* st_name = "smallint_insert";
+    const char* st_name = "inet_insert";
     PgSqlTaggedStatement statement[] = {
         { 1, { OID_TEXT }, st_name,
           "INSERT INTO BASICS (inet_col) values (cast($1 as inet))" }
@@ -1147,6 +1147,59 @@ TEST_F(PgSqlBasicsTest, inetTest6) {
     ASSERT_TRUE(PgSqlExchange::isColumnNull(*r, 0, INET_COL));
 }
 
+/// @brief Verify that we can read and write floats
+TEST_F(PgSqlBasicsTest, floatTest) {
+    // Create a prepared statement for inserting a SMALLINT
+    const char* st_name = "float_insert";
+    PgSqlTaggedStatement statement[] = {
+        { 1, { OID_TEXT }, st_name,
+          "INSERT INTO BASICS (float_col) values (cast($1 as float))" }
+    };
+
+    ASSERT_NO_THROW(conn_->prepareStatement(statement[0]));
+
+    // Build our reference list of reference values
+    std::vector<double>floats;
+    floats.push_back(1.345);
+    floats.push_back(200);
+
+    // Insert a row for each reference value
+    PsqlBindArrayPtr bind_array;
+    PgSqlResultPtr r;
+    for (int i = 0; i < floats.size(); ++i) {
+        bind_array.reset(new PsqlBindArray());
+        bind_array->add(floats[i]);
+        RUN_PREP(r, statement[0], bind_array, PGRES_COMMAND_OK);
+    }
+
+    // Fetch the newly inserted rows.
+    FETCH_ROWS(r, floats.size());
 
+    // Iterate over the rows, verifying each value against its reference
+    int row = 0;
+    for ( ; row  < floats.size(); ++row ) {
+        // Verify the column is not null.
+        ASSERT_FALSE(PgSqlExchange::isColumnNull(*r, row, FLOAT_COL));
+
+        // Fetch and verify the column value
+        double fetched_float;
+        ASSERT_NO_THROW(PgSqlExchange::getColumnValue(*r, row, FLOAT_COL, fetched_float));
+        EXPECT_EQ(fetched_float, floats[row]);
+    }
+
+    // Clean out the table
+    WIPE_ROWS(r);
+
+    // Verify we can insert a NULL value.
+    bind_array.reset(new PsqlBindArray());
+    bind_array->addNull();
+    RUN_PREP(r, statement[0], bind_array, PGRES_COMMAND_OK);
+
+    // Fetch the newly inserted row.
+    FETCH_ROWS(r, 1);
+
+    // Verify the column is null.
+    ASSERT_TRUE(PgSqlExchange::isColumnNull(*r, 0, FLOAT_COL));
+}
 
 }; // namespace