From: Gary Lockyer <gary@catalyst.net.nz>
Date: Mon, 22 Jan 2018 22:02:28 +0000 (+1300)
Subject: ldb_mod_op_test: Fix core dump on ldb_case_attrs_index_test_teardown
X-Git-Tag: talloc-2.1.12~262
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c4c64ff51f7ee6a332f71f093ffd37e06745e785;p=thirdparty%2Fsamba.git

ldb_mod_op_test: Fix core dump on ldb_case_attrs_index_test_teardown

With no schema syntax, this would occasionally crash as it dereferenced
some possibly NULL sequence of memory.

Note: Removing all tests except this one, made it crash reliably.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/tests/ldb_mod_op_test.c b/lib/ldb/tests/ldb_mod_op_test.c
index 766ca798335..5878143d8f6 100644
--- a/lib/ldb/tests/ldb_mod_op_test.c
+++ b/lib/ldb/tests/ldb_mod_op_test.c
@@ -2587,6 +2587,14 @@ static void test_ldb_attrs_index_handler(void **state)
 						    syntax, &cn_attr_2);
 	assert_int_equal(ret, LDB_SUCCESS);
 
+	syntax = ldb_standard_syntax_by_name(ldb, LDB_SYNTAX_OCTET_STRING);
+	assert_non_null(syntax);
+
+	ret = ldb_schema_attribute_fill_with_syntax(ldb, ldb,
+						    "", 0,
+						    syntax, &default_attr);
+	assert_int_equal(ret, LDB_SUCCESS);
+
 	/*
 	 * Set an attribute handler
 	 */