From: Gregory P. Smith Date: Mon, 5 May 2025 04:41:22 +0000 (-0700) Subject: [GH-133419] fix test_external_inspection race assert (#133422) X-Git-Tag: v3.14.0b1~63 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c4cc5d58aee6a3be55a95efee6ec25d5774f7b5f;p=thirdparty%2FPython%2Fcpython.git [GH-133419] fix test_external_inspection race assert (#133422) [tests] fix test_external_inspection race assert either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line. --- diff --git a/Lib/test/test_external_inspection.py b/Lib/test/test_external_inspection.py index 40c21c830c04..a2bce4781df0 100644 --- a/Lib/test/test_external_inspection.py +++ b/Lib/test/test_external_inspection.py @@ -59,8 +59,7 @@ class TestGetStackTrace(unittest.TestCase): foo() def foo(): - sock.sendall(b"ready") - time.sleep(1000) + sock.sendall(b"ready"); time.sleep(1000) # same line number bar() """ @@ -96,10 +95,10 @@ class TestGetStackTrace(unittest.TestCase): p.wait(timeout=SHORT_TIMEOUT) expected_stack_trace = [ - ("foo", script_name, 15), + ("foo", script_name, 14), ("baz", script_name, 11), ("bar", script_name, 9), - ("", script_name, 17), + ("", script_name, 16), ] self.assertEqual(stack_trace, expected_stack_trace)